You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/10 08:34:28 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

zhuzhurk opened a new pull request #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825
 
 
   ## What is the purpose of the change
   
   In JobResult#createFrom it sets the latest global failure cause of the ExecutionGraph to be the cause of the JobResult if the job is terminated but not FINISHED.
   So if the job is CANCELED and any global failure had ever happened, the latest global failure cause would be shown as the root cause of the canceling. This results in a misleading root cause exception when a user cancels the job.
   
   ## Brief change log
   
     - *Changed JobResult to take ExecutionGraph failure cause as its failure cause only if the job is FAILED*
    - *also checked the failure cause to be not null if a job is FAILED*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *Fixed testCancelledJobThrowsJobCancellationException*
     - *Added testFailureResultRequiresFailureCause*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk merged pull request #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-573517594
 
 
   Thanks @tillrohrmann. Will try to backport the fix to release-1.9.
   Merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144099911 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   * 9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144099911) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144099911 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   * 9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144099911) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572929813
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7d66fc50c8749017788386efb2908ae2087ad7fa (Fri Jan 10 08:36:33 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   * 9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10825: [FLINK-15522][runtime] JobResult takes ExecutionGraph failure cause as its failure cause only if job is FAILED
URL: https://github.com/apache/flink/pull/10825#issuecomment-572937976
 
 
   <!--
   Meta data
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143859136 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:7d66fc50c8749017788386efb2908ae2087ad7fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251 TriggerType:PUSH TriggerID:7d66fc50c8749017788386efb2908ae2087ad7fa
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144099911 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   Hash:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280 TriggerType:PUSH TriggerID:9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7
   -->
   ## CI report:
   
   * 7d66fc50c8749017788386efb2908ae2087ad7fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143859136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4251) 
   * 9b83f5d4bdb8a48a3960551a3be34c2c8c2c9cf7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144099911) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4280) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services