[GitHub] [airflow] jedcunningham commented on a diff in pull request #25419: WIP: Create a pluggable DatasetEventManager

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25419:
URL: https://github.com/apache/airflow/pull/25419#discussion_r938286229


##########
airflow/models/dataset.py:
##########
@@ -203,6 +206,44 @@ def __repr__(self):
         return f"{self.__class__.__name__}({', '.join(args)})"
 
 
+class DatasetEventManager(LoggingMixin):
+    """
+    A pluggable class that manages operations for dataset events.
+
+    The intent is to have one place to handle all DatasetEvent-related operations, so different
+    Airflow deployments can use plugins that broadcast dataset events to each other.
+    """
+
+    def register_dataset_change(
+        self, *, task_instance=None, dataset=None, session: Session = NEW_SESSION

Review Comment:
   I don't have a strong preference here. I'm okay with both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org