[kudu-CR] KUDU-2069 pt 1: add a maintenance mode

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14111 )

Change subject: KUDU-2069 pt 1: add a maintenance mode
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/master.proto
File src/kudu/master/master.proto:

http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/master.proto@230
PS6, Line 230:   optional MaintenanceStatePB state = 1;
> I see the allure of using MaintenenanceStatePB for both the persistent stat
Ack

I'll be happy to add more troubleshooting state once the core functionality of this is ironed out. As it stands, troubleshooting isn't easy regardless, since there isn't a way to display maintenance states.


http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/master.proto@820
PS6, Line 820:   // TODO(awong): consider setting maintenance state in batches.
> Yeah, how about making this a 'repeated' now? Otherwise we'd have to break 
Mentioned this on Slack, but it's backwards compatible going from optional to repeated, and I'd rather not worry about bulk writing right now.


http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/master.proto@824
PS6, Line 824: message SetMaintenanceStateResponsePB {
> In anticipation of decommissioning, perhaps we should call this SetTabletSe
Done


http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/14111/6/src/kudu/master/sys_catalog.cc@469
PS6, Line 469:         Status::Corruption("One or more rows failed to write");
> Is this ever more useful than returning the first row error?
Probably not, but I ended up not needing this, so I'm leaving it in its original state.



-- 
To view, visit http://gerrit.cloudera.org:8080/14111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia857668b87560cdd451c2e7f90d72f8217ba5a4b
Gerrit-Change-Number: 14111
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 12 Sep 2019 17:55:36 +0000
Gerrit-HasComments: Yes