You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by shellbj <gi...@git.apache.org> on 2015/09/02 21:47:50 UTC
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
GitHub user shellbj opened a pull request:
https://github.com/apache/storm/pull/715
STORM-1026: Expand external classpaths to include any jars
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shellbj/storm STORM-1026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 62ab4bc114a42115bfdcae2a38456548138a9b0d
Author: Bryan Shell <br...@orbitz.com>
Date: 2015-09-02T19:45:04Z
STORM-1026: Expand external classpaths to include any jars
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/715#issuecomment-142032723
@shellbj and @HeartSaVioR thanks for the patch and the review, sorry it took so long to get this merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/715#issuecomment-142001284
Sorry to being late, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/715#discussion_r38604124
--- Diff: bin/storm.py ---
@@ -103,6 +103,12 @@ def get_config_opts():
sys.exit(1)
def get_jars_full(adir):
+ files = []
+ if os.path.isdir(adir):
+ files = os.listdir(adir)
+ elif os.path.exists(adir):
+ files = [aidr]
+
files = os.listdir(adir)
--- End diff --
This line should be removed to accomplish above lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1026: Expand external classpaths to incl...
Posted by shellbj <gi...@git.apache.org>.
Github user shellbj commented on a diff in the pull request:
https://github.com/apache/storm/pull/715#discussion_r38932103
--- Diff: bin/storm.py ---
@@ -103,6 +103,12 @@ def get_config_opts():
sys.exit(1)
def get_jars_full(adir):
+ files = []
+ if os.path.isdir(adir):
+ files = os.listdir(adir)
+ elif os.path.exists(adir):
+ files = [aidr]
+
files = os.listdir(adir)
--- End diff --
Good catch; updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---