You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "adelapena (via GitHub)" <gi...@apache.org> on 2023/05/15 11:11:10 UTC
[GitHub] [cassandra] adelapena commented on a diff in pull request #2329: CASSANDRA-18521: Unify CQLTester#waitForIndex and SAITester#waitForIndexQueryable
adelapena commented on code in PR #2329:
URL: https://github.com/apache/cassandra/pull/2329#discussion_r1193685746
##########
test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexOnMapEntriesTest.java:
##########
@@ -230,7 +230,7 @@ public void testShouldRejectQueriesForNullEntries() throws Throwable
public void testShouldTreatQueriesAgainstFrozenMapIndexesAsInvalid() throws Throwable
{
createTable("CREATE TABLE %s (k TEXT PRIMARY KEY, v FROZEN<MAP<TEXT, TEXT>>)");
- createIndex("CREATE INDEX ON %s(FULL(V))");
+ createIndexAsync("CREATE INDEX ON %s(FULL(V))");
Review Comment:
Changed to `createIndex`. I have found many of this, most uses of `createAsync` are for indexes that use either an injection or a custom implementation that will fail or block the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org