You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/31 23:18:46 UTC

[GitHub] [openwhisk] tysonnorris commented on a change in pull request #4957: improve http graceful termination

tysonnorris commented on a change in pull request #4957:
URL: https://github.com/apache/openwhisk/pull/4957#discussion_r480467826



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/http/BasicHttpService.scala
##########
@@ -156,24 +163,50 @@ trait BasicHttpService extends Directives {
 }
 
 object BasicHttpService {
+  implicit val tid = TransactionId(systemPrefix + "http_service")
+  //start with ready true
+  protected[http] var ready = true

Review comment:
       The `ready` var? It is used to alter the response to `/ready` endpoint defined in `BasicRasService`.
   I'll try to refactor this so that we're not modifying the object var from different places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org