You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/20 15:17:33 UTC
[GitHub] [pulsar] merlimat opened a new pull request #12100: PIP-45: Removed access to ZK client from PulsarService
merlimat opened a new pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100
### Motivation
Removed direct access to ZK client from the `PulsarService` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #12100: PIP-45: Removed access to ZK client from PulsarService
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100#discussion_r712372680
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -325,6 +324,10 @@ public MetadataStoreExtended createConfigurationMetadataStore() throws MetadataS
.build());
}
+ public void closeMetadataServiceSession() throws IOException {
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12100: PIP-45: Removed access to ZK client from PulsarService
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100#discussion_r712293356
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -325,6 +324,10 @@ public MetadataStoreExtended createConfigurationMetadataStore() throws MetadataS
.build());
}
+ public void closeMetadataServiceSession() throws IOException {
Review comment:
this is a public method, is it worth to add a javadoc ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12100: PIP-45: Removed access to ZK client from PulsarService
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org