[GitHub] [incubator-pinot] suvodeep-pyne edited a comment on pull request #5808: [TE] Dashboard Resource Refactor

[GitBox <gi...@apache.org>]

suvodeep-pyne edited a comment on pull request #5808:
URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-670270234


   @jihaozh @akshayrai
   The way this was validated is by doing a diff between an existing set of APIs and the current set.
   
   ```
       GET     /alerts (org.apache.pinot.thirdeye.dashboard.resources.v2.alerts.AlertResource)
       GET     /anomalies/search/anomalyIds/{startTime}/{endTime}/{pageNumber} (org.apache.pinot.thirdeye.dashboard.resources.v2.AnomaliesResource)
       GET     /anomalies/search/time/{startTime}/{endTime}/{pageNumber} (org.apache.pinot.thirdeye.dashboard.resources.v2.AnomaliesResource)
       GET     /anomaly-search (org.apache.pinot.thirdeye.dashboard.resources.v2.anomalies.AnomalySearchResource)
       DELETE  /application/delete/{application} (org.apache.pinot.thirdeye.api.application.ApplicationResource)
       GET     /auth (org.apache.pinot.thirdeye.dashboard.resources.v2.AuthResource)
       POST    /auth/authenticate (org.apache.pinot.thirdeye.dashboard.resources.v2.AuthResource)
       POST    /auth/create-token (org.apache.pinot.thirdeye.dashboard.resources.v2.AuthResource)
       GET     /auth/logout (org.apache.pinot.thirdeye.dashboard.resources.v2.AuthResource)
       POST    /autoOnboard/runAdhoc/{datasource} (org.apache.pinot.thirdeye.dashboard.resources.AutoOnboardResource)
       GET     /cache/ (org.apache.pinot.thirdeye.dashboard.resources.CacheResource)
       POST    /cache/refresh (org.apache.pinot.thirdeye.dashboard.resources.CacheResource)
       POST    /cache/refresh/datasetConfig (org.apache.pinot.thirdeye.dashboard.resources.CacheResource)
       POST    /cache/refresh/metricConfig (org.apache.pinot.thirdeye.dashboard.resources.CacheResource)
       GET     /config/{namespace}/ (org.apache.pinot.thirdeye.dashboard.resources.v2.ConfigResource)
       DELETE  /config/{namespace}/{name} (org.apache.pinot.thirdeye.dashboard.resources.v2.ConfigResource)
       GET     /config/{namespace}/{name} (org.apache.pinot.thirdeye.dashboard.resources.v2.ConfigResource)
       POST    /config/{namespace}/{name} (org.apache.pinot.thirdeye.dashboard.resources.v2.ConfigResource)
       GET     /dashboard/ (org.apache.pinot.thirdeye.dashboard.resources.DashboardResource)
       GET     /dashboard/anomalies/view (org.apache.pinot.thirdeye.dashboard.resources.AnomalyResource)
       GET     /dashboard/anomalies/view/{anomaly_merged_result_id} (org.apache.pinot.thirdeye.dashboard.resources.AnomalyResource)
       POST    /dashboard/anomaly-merged-result/feedback/{anomaly_merged_result_id} (org.apache.pinot.thirdeye.dashboard.resources.AnomalyResource)
       GET     /dashboard/data (org.apache.pinot.thirdeye.dashboard.resources.DashboardResource)
       GET     /dashboard/data/timeseries (org.apache.pinot.thirdeye.dashboard.resources.DashboardResource)
       GET     /dashboard/summary/autoDimensionOrder (org.apache.pinot.thirdeye.dashboard.resources.SummaryResource)
       GET     /dashboard/summary/autoDimensionOrder/v2 (org.apache.pinot.thirdeye.dashboard.resources.SummaryResource)
       GET     /dashboard/summary/manualDimensionOrder (org.apache.pinot.thirdeye.dashboard.resources.SummaryResource)
       GET     /data/agg/granularity/metric/{metricId} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/anomalies/ranges (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/alert (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/anomalies (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/application (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/dataset (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/detection (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/detection-createdby (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/dimensions/metric/{metricId} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/filters/metric/{metricId} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/functionByAlertName (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/functionByAppname (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/functionByName (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/metric (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/autocomplete/subscription (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/datasets (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/heatmap/{metricId}/{currentStart}/{currentEnd}/{baselineStart}/{baselineEnd} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/maxDataTime/metricId/{metricId} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /data/metric/{metricId} (org.apache.pinot.thirdeye.dashboard.resources.v2.DataResource)
       GET     /dataset-auto-onboard/metrics (org.apache.pinot.thirdeye.dataset.DatasetAutoOnboardResource)
       GET     /dataset-auto-onboard/{detectionId} (org.apache.pinot.thirdeye.dataset.DatasetAutoOnboardResource)
       GET     /detection/dataset (org.apache.pinot.thirdeye.detection.DetectionResource)
       POST    /detection/gridsearch (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/health/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/notification/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/predicted-baseline/{anomalyId} (org.apache.pinot.thirdeye.detection.DetectionResource)
       POST    /detection/preview (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/preview/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       POST    /detection/replay/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       POST    /detection/report-anomaly/{detectionConfigId} (org.apache.pinot.thirdeye.detection.DetectionResource)
       DELETE  /detection/report-anomaly/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/rule (org.apache.pinot.thirdeye.detection.DetectionConfigurationResource)
       GET     /detection/subscription-groups (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/subscription-groups/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/{id} (org.apache.pinot.thirdeye.detection.DetectionResource)
       GET     /detection/{id}/anomalies (org.apache.pinot.thirdeye.detection.DetectionResource)
       POST    /entityMapping/create (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       DELETE  /entityMapping/delete/{id} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       POST    /entityMapping/update/{id} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/all (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/fromURN/{fromURN} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/fromURN/{fromURN}/mappingType/{mappingType} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/fromURN/{fromURN}/toURN/{toURN} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/mappingType/{mappingType} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/toURN/{toURN} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       GET     /entityMapping/view/toURN/{toURN}/mappingType/{mappingType} (org.apache.pinot.thirdeye.dashboard.resources.EntityMappingResource)
       POST    /events/create (org.apache.pinot.thirdeye.dashboard.resources.CustomizedEventResource)
       GET     /groups/batch (org.apache.pinot.thirdeye.dashboard.resources.v2.DetectionAlertResource)
       GET     /groups/query (org.apache.pinot.thirdeye.dashboard.resources.v2.DetectionAlertResource)
       GET     /groups/{id} (org.apache.pinot.thirdeye.dashboard.resources.v2.DetectionAlertResource)
       POST    /onboard/create (org.apache.pinot.thirdeye.dashboard.resources.OnboardDatasetMetricResource)
       DELETE  /onboard/delete/{id} (org.apache.pinot.thirdeye.dashboard.resources.OnboardDatasetMetricResource)
       POST    /onboard/update/{id}/{onboarded} (org.apache.pinot.thirdeye.dashboard.resources.OnboardDatasetMetricResource)
       GET     /onboard/view/dataSource/{dataSource}/onboarded/{onboarded} (org.apache.pinot.thirdeye.dashboard.resources.OnboardDatasetMetricResource)
       GET     /rootcause/highlights (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseResource)
       GET     /rootcause/metric/aggregate (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseMetricResource)
       GET     /rootcause/metric/aggregate/batch (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseMetricResource)
       GET     /rootcause/metric/aggregate/chunk (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseMetricResource)
       GET     /rootcause/metric/breakdown (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseMetricResource)
       GET     /rootcause/metric/timeseries (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseMetricResource)
       GET     /rootcause/query (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseResource)
       GET     /rootcause/raw (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseResource)
       POST    /rootcause/template/saveDimensionAnalysis (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseTemplateResource)
       GET     /rootcause/template/search (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseTemplateResource)
       POST    /session/ (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseSessionResource)
       GET     /session/query (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseSessionResource)
       GET     /session/{sessionId} (org.apache.pinot.thirdeye.dashboard.resources.v2.RootCauseSessionResource)
       GET     /sql-data-source/databases (org.apache.pinot.thirdeye.datasource.sql.resources.SqlDataSourceResource)
       POST    /sql-data-source/onboard (org.apache.pinot.thirdeye.datasource.sql.resources.SqlDataSourceResource)
       GET     /swagger (io.federecio.dropwizard.swagger.SwaggerResource)
       GET     /swagger.{type:json|yaml} (io.swagger.jaxrs.listing.ApiListingResource)
       GET     /thirdeye-admin/ (org.apache.pinot.thirdeye.dashboard.resources.AdminResource)
       GET     /thirdeye-admin/dataset-config/list (org.apache.pinot.thirdeye.dashboard.resources.DatasetConfigResource)
       GET     /thirdeye-admin/dataset-config/view/{dataset} (org.apache.pinot.thirdeye.dashboard.resources.DatasetConfigResource)
       GET     /thirdeye-admin/metric-config/create (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       POST    /thirdeye-admin/metric-config/create/payload (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/delete (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/list (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/metrics (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/update (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/view (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye-admin/metric-config/view/dataset/{dataset} (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       PUT     /thirdeye-admin/metric-config/{id}/create-tag (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       PUT     /thirdeye-admin/metric-config/{id}/remove-tag (org.apache.pinot.thirdeye.dashboard.resources.MetricConfigResource)
       GET     /thirdeye/ (org.apache.pinot.thirdeye.dashboard.resources.ThirdEyeResource)
       GET     /thirdeye/entity (org.apache.pinot.thirdeye.dashboard.resources.EntityManagerResource)
       POST    /thirdeye/entity (org.apache.pinot.thirdeye.dashboard.resources.EntityManagerResource)
       GET     /thirdeye/entity/{entityType} (org.apache.pinot.thirdeye.dashboard.resources.EntityManagerResource)
       GET     /thirdeye/table (org.apache.pinot.thirdeye.dashboard.resources.AnomalyFlattenResource)
       GET     /userdashboard/anomalies (org.apache.pinot.thirdeye.api.user.dashboard.UserDashboardResource)
       POST    /yaml (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       PUT     /yaml/activation/{id} (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/create-alert (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/create-or-update (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       GET     /yaml/list (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       PUT     /yaml/notify/{id} (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/preview (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/preview/baseline (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/preview/{id} (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/subscription (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       POST    /yaml/subscription/create-or-update (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       PUT     /yaml/subscription/{id} (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
       PUT     /yaml/{id} (org.apache.pinot.thirdeye.detection.yaml.YamlResource)
   ```
   
   Out of which I think these 2 were added recently in the last 2 days.
   ```
       GET     /anomaly-search (org.apache.pinot.thirdeye.dashboard.resources.v2.anomalies.AnomalySearchResource)
       GET     /dashboard/summary/autoDimensionOrder/v2 (org.apache.pinot.thirdeye.dashboard.resources.SummaryResource)
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org