[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #375: Fixed issues with resetting variables

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #375:
URL: https://github.com/apache/incubator-daffodil/pull/375#discussion_r418724033



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PState.scala
##########
@@ -220,6 +221,7 @@ final class PState private (
       if (variable.isDefined)
         variable.get.reset
     }}
+    changedVariablesStack.top.clear

Review comment:
       So we're back to having to clear this again now. Please add comment as to why? Not obvious to me that we need this.

##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
##########
@@ -332,6 +331,8 @@ abstract class SequenceParserBase(
         case other => Assert.invariantFailed("Unexpected parse attempt status: " + other)
       }
 
+    if (hasPoU) pstate.popPointOfUncertainty

Review comment:
       This looks like the unwinding bug fix. Yes?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org