You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/09/09 09:06:59 UTC

[GitHub] [systemds] ywcb00 commented on pull request #1381: [SYSTEMDS-3086] Federated WDivMM - Federated Output

ywcb00 commented on pull request #1381:
URL: https://github.com/apache/systemds/pull/1381#issuecomment-915902834


   It wasn't overwritten on purpose.
   
   The additional methods are already taken from the current test cases, but the tests do not verify that the output is kept federated.
   We should definitely change the tests so that they fail if the output is not federated when it should be.
   Since this is the case with several instructions, I will create a new jira task for this and add it with another PR.
   
   Btw, do you know any better possibility to verify the federated output than performing an additional (unary) instruction on it (e.g., _fed_!=_) and verifying that this additional instruction is performed federated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org