You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by xv...@apache.org on 2019/05/07 04:02:51 UTC

[incubator-druid] branch master updated: fix test pattern matching for jdk11 (#7602)

This is an automated email from the ASF dual-hosted git repository.

xvrl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new b3c7463  fix test pattern matching for jdk11 (#7602)
b3c7463 is described below

commit b3c74630592000b692fa0ac4aecbbac79ea14356
Author: Xavier Léauté <xv...@apache.org>
AuthorDate: Mon May 6 21:02:44 2019 -0700

    fix test pattern matching for jdk11 (#7602)
    
    This change makes the error pattern more generic to account for
    differences between JDK versions.
---
 .../common/task/AppenderatorDriverRealtimeIndexTaskTest.java     | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTaskTest.java b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTaskTest.java
index 3155ac9..413e122 100644
--- a/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTaskTest.java
+++ b/indexing-service/src/test/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTaskTest.java
@@ -161,6 +161,7 @@ import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.Executor;
 import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
 
 public class AppenderatorDriverRealtimeIndexTaskTest
 {
@@ -1242,8 +1243,12 @@ public class AppenderatorDriverRealtimeIndexTaskTest
 
       IngestionStatsAndErrorsTaskReportData reportData = getTaskReportData();
       Assert.assertEquals(expectedMetrics, reportData.getRowStats());
-      Assert.assertTrue(status.getErrorMsg()
-                              .contains("java.lang.IllegalArgumentException\n\tat java.nio.Buffer.position"));
+
+      Pattern errorPattern = Pattern.compile(
+          "(?s)java\\.lang\\.IllegalArgumentException.*\n"
+          + "\tat (java\\.base/)?java\\.nio\\.Buffer\\..*"
+      );
+      Assert.assertTrue(errorPattern.matcher(status.getErrorMsg()).matches());
     }
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org