You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/10/18 02:24:58 UTC
Review Request 39416: Document --egress_unique_flow_per_container in
docs/configuration.md
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos
Description
-------
Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
Diffs
-----
docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6
Diff: https://reviews.apache.org/r/39416/diff/
Testing
-------
None.
Thanks,
Cong Wang
Re: Review Request 39416: Document --egress_unique_flow_per_container
in docs/configuration.md
Posted by Cong Wang <cw...@twopensource.com>.
> On Oct. 27, 2015, 5:35 p.m., Ian Downes wrote:
> > docs/configuration.md, lines 1533-1534
> > <https://reviews.apache.org/r/39416/diff/1/?file=1100526#file1100526line1533>
> >
> > Does it actually create a flow per container or is it really based on the 5 tuple, which will be different for different containers?
Yes, the flow is per container, rather than based on tuples.
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/#review104117
-----------------------------------------------------------
On Oct. 18, 2015, 12:24 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39416/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 12:24 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
>
>
> Diffs
> -----
>
> docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6
>
> Diff: https://reviews.apache.org/r/39416/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 39416: Document --egress_unique_flow_per_container
in docs/configuration.md
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/#review104117
-----------------------------------------------------------
docs/configuration.md (lines 1533 - 1534)
<https://reviews.apache.org/r/39416/#comment162355>
Does it actually create a flow per container or is it really based on the 5 tuple, which will be different for different containers?
- Ian Downes
On Oct. 17, 2015, 5:24 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39416/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2015, 5:24 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
>
>
> Diffs
> -----
>
> docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6
>
> Diff: https://reviews.apache.org/r/39416/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 39416: Document --egress_unique_flow_per_container
in docs/configuration.md
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/#review107273
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 19, 2015, 8:09 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39416/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:09 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
>
>
> Diffs
> -----
>
> docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
>
> Diff: https://reviews.apache.org/r/39416/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 39416: Document --egress_unique_flow_per_container
in docs/configuration.md
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/
-----------------------------------------------------------
(Updated Nov. 19, 2015, 8:09 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Changes
-------
Rebase
Repository: mesos
Description
-------
Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
Diffs (updated)
-----
docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
Diff: https://reviews.apache.org/r/39416/diff/
Testing
-------
None.
Thanks,
Cong Wang
Re: Review Request 39416: Document --egress_unique_flow_per_container
in docs/configuration.md
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39416/
-----------------------------------------------------------
(Updated Oct. 29, 2015, 12:12 a.m.)
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos
Description
-------
Flag --egress_unique_flow_per_container is documented in help message, but not in docs/configuration.md. We should document it there too, with more details.
Diffs (updated)
-----
docs/configuration.md ae9f2612b11447eff92ea85d4191e7011d71b2b2
Diff: https://reviews.apache.org/r/39416/diff/
Testing
-------
None.
Thanks,
Cong Wang