[GitHub] [spark] JoshRosen commented on a change in pull request #34353: [SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to bytesConf

[GitBox <gi...@apache.org>]

JoshRosen commented on a change in pull request #34353:
URL: https://github.com/apache/spark/pull/34353#discussion_r733910512



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1415,8 +1415,8 @@ object SQLConf {
       " bigger files (which is scheduled first). This configuration is effective only when using" +
       " file-based sources such as Parquet, JSON and ORC.")
     .version("2.0.0")
-    .longConf
-    .createWithDefault(4 * 1024 * 1024)
+    .bytesConf(ByteUnit.BYTE)
+    .createWithDefaultString("4MB")

Review comment:
       +1; we could probably extend this existing test:
   
   https://github.com/apache/spark/blob/4148fb58aada5bb7bc4835b39fe1baa07f9bacce/core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala#L90-L97




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org