You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2024/11/10 18:16:15 UTC

[PR] Add GH Actions for UI tests [jena]

kinow opened a new pull request, #2835:
URL: https://github.com/apache/jena/pull/2835

   Ref: https://github.com/apache/jena/pull/2830#issuecomment-2466641867
   
   Pull request Description:
   
   This PR adds GitHub Actions for the UI tests.
   
   Tested on my fork:
   
   - Created a quick YAML version (knew it was probably broken, doesn't matter as I wanted to add it to my `main`)
   - Pushed it to `kinow/jena`'s `main`
   - Then [created  PR](https://github.com/kinow/jena/pull/36) to fix it, which now could be used to validate it worked
   - 8 commits later, got it to work, tests took 1 min e2e, and 2 min the unit (because e2e is pure `yarn`, but for unit I used `mvn` -- just to make sure UI is not broken when Maven is used?)
   - Squashed, cherry-picked the commit from this PR to prepare this PR
   - Added the `if` to check for `apache/jena` as the repository
   
   Now once this is merged we can rebase a dependabot or some other UI PR and :crossed_fingers: it will work.
   
   ![image](https://github.com/user-attachments/assets/34809fcf-a7f4-4e68-9a04-829f71016be7)
   
   
   ----
   
    - [ ] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
    - [x] Commits have been squashed to remove intermediate development commit messages.
    - [ ] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Add GH Actions for UI tests [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #2835:
URL: https://github.com/apache/jena/pull/2835#issuecomment-2473453188

   Looks good. 
   
   > 8 commits later, got it to work
   
   😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Add GH Actions for UI tests [jena]

Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2835:
URL: https://github.com/apache/jena/pull/2835#issuecomment-2466834936

   To test the `if` that verifies the repository being `apache/jena`, I also created https://github.com/afs/jena/pull/209.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Add GH Actions for UI tests [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #2835:
URL: https://github.com/apache/jena/pull/2835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org