You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "rafsun42 (via GitHub)" <gi...@apache.org> on 2023/07/06 15:42:51 UTC

[GitHub] [age] rafsun42 commented on a diff in pull request #1015: Merge of PG12 into the master branch.

rafsun42 commented on code in PR #1015:
URL: https://github.com/apache/age/pull/1015#discussion_r1254620318


##########
src/backend/utils/adt/agtype.c:
##########
@@ -151,25 +159,25 @@ static bool is_array_path(agtype_value *agtv);
 /* graph entity retrieval */
 static Datum get_vertex(const char *graph, const char *vertex_label,
                         int64 graphid);
-static char *get_label_name(const char *graph_name, int64 graph_id);
+static char *get_label_name(const char *graph_name, int64 label_id);

Review Comment:
   The second parameter is a vertex\edge ID (as seen in where the function is called from). Not a label ID.
   
   Ideally, the type should be `graphid` instead of `int64`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org