You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/11/16 16:17:52 UTC

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation
URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151462675
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCounter.java
 ##########
 @@ -22,6 +22,7 @@
 package org.apache.bookkeeper.client;
 
 import java.util.Enumeration;
+import org.apache.bookkeeper.client.api.LedgerEntry;
 
 Review comment:
   Thanks, it is needed after we doing this refine. originally, it references the implementation of LedgerEntry in org.apache.bookkeeper.client.LedgerEntry; while after this change, neither the impl nor interface is in the same package, and not access-able.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services