You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/25 18:43:37 UTC

[kudu-CR] [util] handle OpenSSL errors in JWT code

Hello Tidy Bot, Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19799

to look at the new patch set (#2).

Change subject: [util] handle OpenSSL errors in JWT code
......................................................................

[util] handle OpenSSL errors in JWT code

While looking at ~50% flakiness stats for the newly added JWT test,
I that found the root cause of the issue was a non-handled error left
at the error stack of the OpenSSL library.

When looking at the code in jwt-util.cc, it turned out the usage of the
OpenSSL API in ConvertJwkToPem() methods was a bit fragile: possible
errors returned by OpenSSL functions were not properly handled.

While this patch doesn't fix the flakiness in the JWT test, it addresses
the issue with the unhandled OpenSSL errors in the JWT wrapper code.

Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670
---
M src/kudu/util/jwt-util-internal.h
M src/kudu/util/jwt-util.cc
2 files changed, 124 insertions(+), 81 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/19799/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac5142c1dcaeec5042217e1c90f8e8770b36a670
Gerrit-Change-Number: 19799
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>