You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2014/12/18 00:36:10 UTC
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
GitHub user mbalassi opened a pull request:
https://github.com/apache/incubator-flink/pull/274
[dist] Updated the assembly of the examples subdirectory
Excluded the scala example jars
Included the java example source code
Now the examples subdir contins the individual java jars for each example and a subdir for the java and scala source code respectively. If I remember well this was the suggested conclusion of the discussion in #199.
I consider this a fix for the 0.8 release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/incubator-flink assembly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit 521a8417d3f505a0e7c06c86a6d0a22997b18916
Author: mbalassi <mb...@apache.org>
Date: 2014-12-17T23:28:07Z
[dist] Updated the assembly of the examples subdirectory
Excluded the scala example jars
Included the java example source code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/274#issuecomment-67496422
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/incubator-flink/pull/274#issuecomment-67496669
I'm personally also against the java-src and scala-src subdirectories, but that was in the assembly before I have touched it (the java was not working because of a typo though).
Can I remove those then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/274#issuecomment-67496965
Yes. Remove both of them :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [dist] Updated the assembly of the e...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/274#issuecomment-67494870
I'm not sure if these "java-src" and "scala-src" directories in the binary release are a good idea at all. The files there are not really usable because they are no maven projects.
Also, it is quite uncommon to have something like this. If nobody objects, I would vote to remove it.
Looks good. I haven't tested it. But if its working I'm +1 with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---