[GitHub] [incubator-openwhisk] chetanmeh commented on a change in pull request #4334: Feature flag support to turn on/off support for provide-api-key annotation

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4334: Feature flag support to turn on/off support for provide-api-key annotation
URL: https://github.com/apache/incubator-openwhisk/pull/4334#discussion_r265135687
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
 ##########
 @@ -67,7 +67,7 @@ object WhiskActionsApi {
    * 2. An [[execAnnotation]] consistent with the action kind; this annotation is always added and overrides a pre-existing value
    */
   protected[core] def amendAnnotations(annotations: Parameters, exec: Exec, create: Boolean = true): Parameters = {
-    val newAnnotations = if (create) {
+    val newAnnotations = if (create && FeatureFlags.requireApiKeyAnnotation) {
 
 Review comment:
   For now I do not think that we should make test case complex with feature flag support. So test should work assuming all new features enabled (unless using some SPI mechanism). For main code we just validate manually that if feature is disabled then we get back the earlier behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services