You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/04/06 16:01:47 UTC
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/596
TINKERPOP-1443 API Checker
https://issues.apache.org/jira/browse/TINKERPOP-1443
This is basically the continuation to #494 - didn't really change anything though @dkuppitz did get docker working. Travis seems ok with the build as well. No one seemed to have a problem with requiring maven 3.2.5 or better for our build (see the linked DISCUSS thread in JIRA), so keep in mind that if you run an earlier version it will cause trouble (only on the master branch obviously).
I guess we will need a release of 3.3.0 before we will have any real use out of this as breaking changes are allowed between our last release on 3.2.x and our future 3.3.0.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1443
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #596
----
commit 25752d23782652d55615540b15a1ee8bf0b3ac49
Author: Lukas Krejci <lk...@redhat.com>
Date: 2016-11-14T22:55:23Z
Introduce Revapi API checks into the build.
The API checker is set up to only check classes in org.apache.tinkerpop
package (and sub packages) and is set up to ignore breaking changes
on a minor version increase.
It always reports non-public classes that leak into the API though.
commit ddb76a6092bd2e021b7f89cdb325b5350a9cbc60
Author: Lukas Krejci <lk...@redhat.com>
Date: 2016-11-15T10:21:34Z
Make Travis use a newer version of Maven.
commit d73933bf4f103c61ba063cd616c29b354f21c4cf
Author: Lukas Krejci <lk...@redhat.com>
Date: 2016-11-28T22:28:06Z
Finalize Revapi setup:
* Switched off by default with only gremlin-core having it active
* Explicitly sets the severity of problems to fail the build with to
"potentiallyBreaking".
* The parent pom only includes common setup.
* Other setup (like what packages to include in a check and what changes
to ignore because they are intentional) is externalized into
per-module configuration files.
commit e42cfa7b041217ff244710aa20c752ec65ee3f61
Author: Lukas Krejci <lk...@redhat.com>
Date: 2017-01-06T22:24:57Z
Upgrade to latest revapi versions.
commit a09c4c347c4e89a21b240f07bfb01178956970a0
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2017-04-06T12:40:05Z
install Maven 3.3.9 as part of the Docker build process
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/596#discussion_r110668972
--- Diff: .travis.yml ---
@@ -5,6 +5,18 @@ jdk:
- oraclejdk8
sudo: required
dist: trusty
+cache:
+ directories:
+ - $HOME/mvn-home
+
+install:
+ # install maven 3.3.9 if it is not in cache already
--- End diff --
I'm not sure I see why it matters. The requirement is at least 3.2.5 and 3.3.9 meets that requirement. I suppose we could pin travis to the minimum version but is there any particular reason to do so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #596: TINKERPOP-1443 API Checker
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/596
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/596#discussion_r110670226
--- Diff: .travis.yml ---
@@ -5,6 +5,18 @@ jdk:
- oraclejdk8
sudo: required
dist: trusty
+cache:
+ directories:
+ - $HOME/mvn-home
+
+install:
+ # install maven 3.3.9 if it is not in cache already
--- End diff --
right, consistency and built-in testing for the stated minimum Maven level. probably no big deal either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/596#discussion_r110478292
--- Diff: .travis.yml ---
@@ -5,6 +5,18 @@ jdk:
- oraclejdk8
sudo: required
dist: trusty
+cache:
+ directories:
+ - $HOME/mvn-home
+
+install:
+ # install maven 3.3.9 if it is not in cache already
--- End diff --
Need an update on the Maven version to 3.3.9 in [`development-environment.asciidoc`](https://github.com/apache/tinkerpop/blob/master/docs/src/dev/developer/development-environment.asciidoc#system-configuration). Would be good to add `requireMavenVersion` to the [`pom.xml`](https://github.com/apache/tinkerpop/blob/master/pom.xml#L178) also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/596#discussion_r110639896
--- Diff: .travis.yml ---
@@ -5,6 +5,18 @@ jdk:
- oraclejdk8
sudo: required
dist: trusty
+cache:
+ directories:
+ - $HOME/mvn-home
+
+install:
+ # install maven 3.3.9 if it is not in cache already
--- End diff --
Pushed fixes for both of those. Note that 3.2.5 is the actual minimum maven version required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/596#discussion_r110667764
--- Diff: .travis.yml ---
@@ -5,6 +5,18 @@ jdk:
- oraclejdk8
sudo: required
dist: trusty
+cache:
+ directories:
+ - $HOME/mvn-home
+
+install:
+ # install maven 3.3.9 if it is not in cache already
--- End diff --
then shouldn't Travis use 3.2.5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #596: TINKERPOP-1443 API Checker
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #596: TINKERPOP-1443 API Checker
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/596
@pluradj i changed it to 3.2.5 for travis - travis looks happy with the build so i'll prepare to merge today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #596: TINKERPOP-1443 API Checker
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/596
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---