You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/31 04:17:31 UTC
[GitHub] [spark] viirya opened a new pull request #35075: [SPARK-37794][BUILD] Remove log4j bridge api usage
viirya opened a new pull request #35075:
URL: https://github.com/apache/spark/pull/35075
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch removes log4j 1.x bridge api usage.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Although for compatibility reason, we include log4j 1.x bridge api dependency. But for Spark itself, it is better to remove the bridge api usage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass all tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35075:
URL: https://github.com/apache/spark/pull/35075#issuecomment-1003306795
Hive module seems to fail. Could you re-trigger GitHub Action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35075: [SPARK-37794][BUILD] Remove log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35075:
URL: https://github.com/apache/spark/pull/35075#issuecomment-1003263687
Two log4j 1.x bridge API usage I've not removed yet:
`TestUtils.configTestLog4j` and `python/pyspark/testing/utils.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35075:
URL: https://github.com/apache/spark/pull/35075#issuecomment-1003269457
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777045515
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
e.g.,
```
[info] - Query with constant folding the CAST *** FAILED *** (6 milliseconds)
[info] org.apache.spark.sql.AnalysisException: Table or view not found: src; line 1 pos 50;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777045243
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
Got it.
Then, @viirya , does Hive test pass in your local environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35075:
URL: https://github.com/apache/spark/pull/35075#issuecomment-1003468345
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777045561
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
Oops, I made a mistake...let me update...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r776925738
##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -237,6 +231,19 @@ private[spark] object Logging {
"org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
}
+ /**
+ * Return true if log4j2 is initialized by default configuration which has one
+ * appender with error level. See `org.apache.logging.log4j.core.config.DefaultConfiguration`.
+ */
+ private[spark] def islog4j2DefaultConfigured(): Boolean = {
+ val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]
Review comment:
Can we use `import org.apache.logging.log4j.core.Logger` explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r776925837
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreLazyInitializationSuite.scala
##########
@@ -30,7 +30,8 @@ class HiveMetastoreLazyInitializationSuite extends SparkFunSuite {
.enableHiveSupport()
.config("spark.hadoop.hive.metastore.uris", "thrift://127.0.0.1:11111")
.getOrCreate()
- val originalLevel = org.apache.log4j.Logger.getRootLogger().getLevel
+ val originalLevel = org.apache.logging.log4j.LogManager.getRootLogger
Review comment:
Can we use `import org.apache.logging.log4j.LogManager` explicitly?
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreLazyInitializationSuite.scala
##########
@@ -30,7 +30,8 @@ class HiveMetastoreLazyInitializationSuite extends SparkFunSuite {
.enableHiveSupport()
.config("spark.hadoop.hive.metastore.uris", "thrift://127.0.0.1:11111")
.getOrCreate()
- val originalLevel = org.apache.log4j.Logger.getRootLogger().getLevel
+ val originalLevel = org.apache.logging.log4j.LogManager.getRootLogger
+ .asInstanceOf[org.apache.logging.log4j.core.Logger].getLevel
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777044811
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
Hive tests seem to fail consistently on this PR. Do you think this is relevant, @viirya ?
BTW, is the following PR relevant to this, too?
- https://github.com/apache/spark/pull/35080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35075:
URL: https://github.com/apache/spark/pull/35075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777047334
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
It should pass now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #35075:
URL: https://github.com/apache/spark/pull/35075#issuecomment-1003456954
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777045424
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
Let me check. This changes logger levels. It shouldn't affect tests unrelated to logging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r777045082
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -535,10 +535,12 @@ private[hive] class TestHiveSparkSession(
def reset(): Unit = {
try {
// HACK: Hive is too noisy by default.
- org.apache.log4j.LogManager.getCurrentLoggers.asScala.foreach { log =>
- val logger = log.asInstanceOf[org.apache.log4j.Logger]
+ org.apache.logging.log4j.LogManager.getContext(false)
Review comment:
#35080 is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org