[GitHub] [flink] aljoscha commented on a change in pull request #8685: [FLINK-12799][table] Improve expression based TableSchema extraction from DataStream/DataSet

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #8685: [FLINK-12799][table] Improve expression based TableSchema extraction from DataStream/DataSet
URL: https://github.com/apache/flink/pull/8685#discussion_r292462257
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/typeutils/FieldInfoUtils.java
 ##########
 @@ -117,14 +171,18 @@ public static boolean isReferenceByPosition(CompositeType<?> ct, Expression[] fi
 	 * @param <A> The type of the TypeInformation.
 	 * @return A tuple of two arrays holding the field names and corresponding field positions.
 	 */
-	public static <A> FieldsInfo getFieldsInfo(TypeInformation<A> inputType) {
+	public static <A> TypeInfoSchema getFieldsInfo(TypeInformation<A> inputType) {
 
 Review comment:
   The Javadoc for this and the next method is now outdated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services