You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 14:18:55 UTC

[GitHub] [flink-kubernetes-operator] gaborgsomogyi opened a new pull request, #449: [FLINK-30176] Fix assert_available_slots when curl is returning empty response

gaborgsomogyi opened a new pull request, #449:
URL: https://github.com/apache/flink-kubernetes-operator/pull/449

   ## What is the purpose of the change
   
   The condition is simply wrong, please see the following case:
   ```
   $ expected=0
   $ actual=""
   $ if [[ expected != actual ]] then echo "Not same"; else echo "Same"; fi
   Same
   ```
   In this PR I've fixed this edge case.
   
   ## Brief change log
   
   Fixed the bash logic.
   
   ## Verifying this change
   
   Existing e2e tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #449: [FLINK-30176] Fix assert_available_slots when curl is returning empty response

Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #449:
URL: https://github.com/apache/flink-kubernetes-operator/pull/449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org