You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/18 03:03:29 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

xiaoxiang781216 commented on a change in pull request #5254:
URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786384684



##########
File path: arch/mips/src/pic32mx/pic32mx_ethernet.c
##########
@@ -215,7 +215,7 @@
  * header
  */
 
-#define BUF ((struct eth_hdr_s *)priv->pd_dev.d_buf)
+#define BUF ((FAR struct eth_hdr_s *)priv->pd_dev.d_buf)

Review comment:
       remove

##########
File path: arch/mips/src/pic32mz/pic32mz_ethernet.c
##########
@@ -254,7 +254,7 @@
  * header
  */
 
-#define BUF ((struct eth_hdr_s *)priv->pd_dev.d_buf)
+#define BUF ((FAR struct eth_hdr_s *)priv->pd_dev.d_buf)

Review comment:
       remove

##########
File path: arch/xtensa/src/esp32/esp32_wlan.c
##########
@@ -1077,7 +1077,7 @@ static void wlan_txtimeout_expiry(wdparm_t arg)
 static void wlan_poll_work(void *arg)
 {
   int32_t delay_tick = WLAN_WDDELAY;
-  FAR struct wlan_priv_s *priv = (FAR struct wlan_priv_s *)arg;

Review comment:
       remove?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org