You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/06/16 22:48:35 UTC
Re: Review Request: SQOOP-943 Sqoop2: Repository wide configuration of
immutable disk structures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9849/
-----------------------------------------------------------
(Updated June 16, 2013, 8:48 p.m.)
Review request for Sqoop.
Changes
-------
Rebased on current HEAD of sqoop2 branch.
Description
-------
I've promote the idea of immutable on disk structures to a first class citizen. I've also removed similar concept from JDBC Repository implementation as it would be duplicating functionality.
This addresses bug SQOOP-943.
https://issues.apache.org/jira/browse/SQOOP-943
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34afc9af0fe0c654c93159809ed93999043b
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 8989fb6fb00a8278f7d6d457dbe5b9193fd2d58e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 3339c597b92131ed87b3ee1a95c1c7d75c5212dc
core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 8939f8a12356155a5bb76b4d8da40ae82abc1506
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 4cae7bafe4086b5c5816b57c5b1eee523f6ece7c
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 955306d1536a53d5ec93b17c2ce1255f3f06df54
dist/src/main/server/conf/sqoop.properties 5131aad897cb765e84d3aec32e0eb05846f01676
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 3620c28a6323f37302ad6a3d877163cf09d9e20f
Diff: https://reviews.apache.org/r/9849/diff/
Testing
-------
Unit and integration tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-943 Sqoop2: Repository wide configuration of
immutable disk structures
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9849/#review22297
-----------------------------------------------------------
Ship it!
Ship It!
- Kathleen Ting
On June 16, 2013, 8:48 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9849/
> -----------------------------------------------------------
>
> (Updated June 16, 2013, 8:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've promote the idea of immutable on disk structures to a first class citizen. I've also removed similar concept from JDBC Repository implementation as it would be duplicating functionality.
>
>
> This addresses bug SQOOP-943.
> https://issues.apache.org/jira/browse/SQOOP-943
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34afc9af0fe0c654c93159809ed93999043b
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 8989fb6fb00a8278f7d6d457dbe5b9193fd2d58e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 3339c597b92131ed87b3ee1a95c1c7d75c5212dc
> core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 8939f8a12356155a5bb76b4d8da40ae82abc1506
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
> core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 4cae7bafe4086b5c5816b57c5b1eee523f6ece7c
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 955306d1536a53d5ec93b17c2ce1255f3f06df54
> dist/src/main/server/conf/sqoop.properties 5131aad897cb765e84d3aec32e0eb05846f01676
> test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 3620c28a6323f37302ad6a3d877163cf09d9e20f
>
> Diff: https://reviews.apache.org/r/9849/diff/
>
>
> Testing
> -------
>
> Unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>