You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "klsince (via GitHub)" <gi...@apache.org> on 2023/07/06 22:49:38 UTC
[GitHub] [pinot] klsince opened a new pull request, #11049: [WIP] format double 0 properly to compare with h2 results
klsince opened a new pull request, #11049:
URL: https://github.com/apache/pinot/pull/11049
`bugfix`
if appending '.0', some tests would fail as Pinot returns 0.0 but H2 returns 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11049: [WIP] format double 0 properly to compare with h2 results
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11049:
URL: https://github.com/apache/pinot/pull/11049#issuecomment-1624434787
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11049](https://app.codecov.io/gh/apache/pinot/pull/11049?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (42957c9) into [master](https://app.codecov.io/gh/apache/pinot/commit/2fabbe40057d99afa497071f7083b4f16e40137a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2fabbe4) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11049 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2199 2200 +1
Lines 118779 118802 +23
Branches 18000 17991 -9
==========================================
Hits 137 137
- Misses 118622 118645 +23
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `0.00% <ø> (ø)` | |
| integration1temurin20 | `0.00% <ø> (ø)` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `0.00% <ø> (ø)` | |
| unittests2temurin11 | `0.11% <ø> (-0.01%)` | :arrow_down: |
| unittests2temurin17 | `0.11% <ø> (-0.01%)` | :arrow_down: |
| unittests2temurin20 | `0.11% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 15 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11049/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on pull request #11049: [WIP] format double 0 properly to compare with h2 results
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince commented on PR #11049:
URL: https://github.com/apache/pinot/pull/11049#issuecomment-1624403253
e.g.
```
Pinot query: SELECT ArrTime, ArrTime + ArrTime * 9 - ArrTime * 10 FROM mytable WHERE ArrTime - 100 > 0
H2 query: SELECT ArrTime, ArrTime + ArrTime * 9 - ArrTime * 10 FROM mytable WHERE ArrTime - 100 > 0
Selection result differ in Pinot from H2: Pinot row: [ 1306 0.0 ] not found in H2 result set: [[810 0 , 535 0 , ... 1843 0 ]].
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince merged pull request #11049: Format double 0 properly to compare with h2 results
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince merged PR #11049:
URL: https://github.com/apache/pinot/pull/11049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org