You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:15:24 UTC
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22801: Add Python nexmark to gradle
TheNeuralBit commented on code in PR #22801:
URL: https://github.com/apache/beam/pull/22801#discussion_r951692345
##########
sdks/python/apache_beam/testing/benchmarks/nexmark/README.md:
##########
@@ -23,22 +23,28 @@
For batch mode, a file needs to be generated first by running java suite and writing events to a file.
-```shell script
-./gradlew :sdks:java:testing:nexmark:run \
- -Pnexmark.runner=":runners:direct-java"
- -Pnexmark.args=" --query=1 --runner=DirectRunner --streaming=false --suite=SMOKE --numEvents=100000 --manageResources=false --monitorJobs=true --enforceEncodability=true --enforceImmutability=true --generateEventFilePathPrefix=YOUR_FILE_PREFIX"
-```
-
### Direct Runner
```shell script
-python nexmark_launcher.py --query 5 --num_events 10000 --runner DirectRunner --input PATH_TO_INPUT_FILE
+./gradlew :sdks:java:testing:nexmark:run \
+ -Pnexmark.runner=":runners:direct-java" \
+ -Pnexmark.args="--query=0 --runner=DirectRunner --numEvents=100000 --manageResources=false --monitorJobs=true --enforceEncodability=true --enforceImmutability=true --generateEventFilePathPrefix=/tmp/eventfile"
+
+./gradlew :sdks:python:apache_beam:testing:benchmarks:nexmark:run \
+ -Pnexmark.args="--query=0 --num_events=100000 --runner=DirectRunner --input=/tmp/eventfile\*"
Review Comment:
It would be interesting to make the former command a pre-requisite for the latter. But I guess that doesn't make sense in the distributed runner + cloud storage case.
##########
sdks/python/apache_beam/testing/benchmarks/nexmark/README.md:
##########
@@ -23,22 +23,28 @@
For batch mode, a file needs to be generated first by running java suite and writing events to a file.
Review Comment:
Should we move this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org