You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/01/06 09:04:48 UTC
[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1860
[ZEPPELIN-1848] add option for S3 KMS key region
### What is this PR for?
When using S3 storage layer with encryption keys, currently only keys created in `us-east-1` region can be used. This PR adds ability to set target region for AWS KMS keys.
### What type of PR is it?
Improvement
### Todos
* [x] - add region to awsClient
* [x] - add conf for region
* [x] - tested with aws account `us-west-2` region
### What is the Jira issue?
[ZEPPELIN-1848](https://issues.apache.org/jira/browse/ZEPPELIN-1848)
### How should this be tested?
1. set up S3 storage as in [here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)
2. add region variable with `export ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION="us-west-2"` in `conf/zeppelin-env.sh`
3. start Zeppelin and read/write S3
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/s3-repo-kms-region
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1860
----
commit da14298570ac6dbc3bbea7bc06a56f4ba1e456a3
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-06T08:41:00Z
add property to ZeppelinConfiguration
commit 311019303216668b32a510761273dcdf8c5fe6e4
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-06T08:41:40Z
add crypt conf to s3 repo
commit d5808cd73fd0c0c36c92ab72f8ebe79994fb2d83
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-06T08:42:58Z
add env vars to .sh
commit 929d4017abcd7b715b99ff32617d445c3585c646
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-06T08:43:23Z
add property to .site
commit 303f16d2b432bd15753be70bdbb3f4661102de9f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-06T09:02:10Z
add documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1860: [ZEPPELIN-1848] add option for S3 KMS key region
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1860
LGTM and merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1860
[ZEPPELIN-1848] add option for S3 KMS key region
### What is this PR for?
When using S3 storage layer with encryption keys, currently only keys created in `us-east-1` region can be used. This PR adds ability to set target region for AWS KMS keys.
### What type of PR is it?
Improvement
### Todos
* [x] - add region to awsClient
* [x] - add conf for region
* [x] - tested with aws account `us-west-2` region
### What is the Jira issue?
[ZEPPELIN-1848](https://issues.apache.org/jira/browse/ZEPPELIN-1848)
### How should this be tested?
1. set up S3 storage as in [here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)
2. add region variable with `export ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION="us-west-2"` in `conf/zeppelin-env.sh`
3. start Zeppelin and read/write S3
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/s3-repo-kms-region
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1860
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---