You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "devCod3r (via GitHub)" <gi...@apache.org> on 2023/04/11 02:32:42 UTC
[GitHub] [eventmesh] devCod3r opened a new pull request, #3692: [Issue #3159] Found reliance on default encoding [RedirectClientByPathHandlerTest]
devCod3r opened a new pull request, #3692:
URL: https://github.com/apache/eventmesh/pull/3692
Fixes #3159
### Motivation
Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms.
Above issue is the reason why this change is introduced.
Issue #3159
### Modifications
Modified response variable of RedirectClientByPathHandlerTest class present in Line 127
Earlier value of response variable used to be outputStream.toString()
New value of response variable is outputStream.toString(Constants.DEFAULT_CHARSET.name());
### Documentation
- Does this pull request introduce a new feature?
- Ans: no
- If a feature is not applicable for documentation, explain why?
- Ans: Modified a variable in RedirectClientByPathHandlerTest class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3692: [ISSUE #3159] Found reliance on default encoding [RedirectClientByPathHandlerTest]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3692:
URL: https://github.com/apache/eventmesh/pull/3692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3692: [Issue #3159] Found reliance on default encoding [RedirectClientByPathHandlerTest]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3692:
URL: https://github.com/apache/eventmesh/pull/3692#issuecomment-1502617947
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3692](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6dd3a1) into [master](https://codecov.io/gh/apache/eventmesh/commit/7f005243389d5c6a7942a35bbf6c5eb306cd9f01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f00524) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head e6dd3a1 differs from pull request most recent head bd63fbf. Consider uploading reports for the commit bd63fbf to get more accurate results
```diff
@@ Coverage Diff @@
## master #3692 +/- ##
============================================
- Coverage 13.76% 13.75% -0.01%
Complexity 1291 1291
============================================
Files 571 571
Lines 29239 29231 -8
Branches 2885 2872 -13
============================================
- Hits 4024 4020 -4
+ Misses 24841 24838 -3
+ Partials 374 373 -1
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/runtime/admin/handler/EventHandler.java](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRXZlbnRIYW5kbGVyLmphdmE=) | `6.25% <0.00%> (+0.06%)` | :arrow_up: |
| [...ntmesh/runtime/admin/handler/TCPClientHandler.java](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVENQQ2xpZW50SGFuZGxlci5qYXZh) | `4.25% <0.00%> (ø)` | |
| [...re/protocol/http/processor/SubscribeProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU3Vic2NyaWJlUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org