You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/11 12:58:43 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #13373: [FLINK-18802] Upgrade avro to 1.10

dawidwys commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487027309



##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/table/runtime/batch/AvroTypesITCase.java
##########
@@ -58,7 +55,7 @@
 @RunWith(Parameterized.class)
 public class AvroTypesITCase extends TableProgramsClusterTestBase {
 
-	private static final User USER_1 = User.newBuilder()
+	private static final SimpleUser USER_1 = SimpleUser.newBuilder()

Review comment:
       Had to drop the logical types, because the `BatchTableEnvironment` fails if we have a `java.time.Instant` in the input DataSet. We extract `BasicTypeInfo.INSTANT_TYPE_INFO` for it, which is translated to `TIMESTAMP_WITH_LOCAL_TIME_ZONE` which fails in legacy planner.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org