You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2010/06/30 23:49:12 UTC

svn commit: r959449 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java

Author: lu4242
Date: Wed Jun 30 21:49:11 2010
New Revision: 959449

URL: http://svn.apache.org/viewvc?rev=959449&view=rev
Log:
MYFACES-2761 PartialViewContextImpl does not respect isRenderAll() (render only viewRoot children, not facets!)

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java?rev=959449&r1=959448&r2=959449&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java Wed Jun 30 21:49:11 2010
@@ -430,18 +430,22 @@ public class PartialViewContextImpl exte
     
     private void processRenderAll(UIViewRoot viewRoot, PartialResponseWriter writer) throws IOException
     {
-        java.util.Iterator<UIComponent> iter = viewRoot.getFacetsAndChildren();
+        //java.util.Iterator<UIComponent> iter = viewRoot.getFacetsAndChildren();
         writer.startUpdate (PartialResponseWriter.RENDER_ALL_MARKER);
-        while (iter.hasNext()) 
-        { 
-            UIComponent comp = iter.next();
+        //while (iter.hasNext()) 
+        //{ 
+            //UIComponent comp = iter.next();
             
             //TODO: Do not check for a specific instance, 
             //just render all children.
             //if (comp instanceof javax.faces.component.html.HtmlBody)
             //{
-                comp.encodeAll (_facesContext);
+                //comp.encodeAll (_facesContext);
             //}
+        //}
+        for (UIComponent comp : viewRoot.getChildren())
+        {
+            comp.encodeAll (_facesContext);
         }
         writer.endUpdate();
     }