svn commit: r1078106 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java

[mg...@apache.org]

Author: mgrigorov
Date: Fri Mar  4 19:12:01 2011
New Revision: 1078106

URL: http://svn.apache.org/viewvc?rev=1078106&view=rev
Log:
* Fix #newClientInfo() javadoc - RequestCycle is not involved anymore.
* Remove 'final' from two methods which delegate to Application. This way custom sessions can modify the default behavior. -- Discussed with Jeremy Thomerson and Igor Vaynberg


Modified:
    wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java

Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java?rev=1078106&r1=1078105&r2=1078106&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Session.java Fri Mar  4 19:12:01 2011
@@ -339,10 +339,7 @@ public abstract class Session implements
 	/**
 	 * Gets the client info object for this session. This method lazily gets the new agent info
 	 * object for this session. It uses any cached or set ({@link #setClientInfo(ClientInfo)})
-	 * client info object or uses {@link RequestCycle#newClientInfo()} to get the info object based
-	 * on the current request when no client info object was set yet, and then caches the returned
-	 * object; we can expect the client to stay the same for the whole session, and implementations
-	 * of {@link RequestCycle#newClientInfo()} might be relatively expensive.
+	 * client info object.
 	 * 
 	 * @return the client info object based on this request
 	 */
@@ -419,7 +416,7 @@ public abstract class Session implements
 	/**
 	 * @return The page factory for this session
 	 */
-	public final IPageFactory getPageFactory()
+	public IPageFactory getPageFactory()
 	{
 		return getApplication().getSessionSettings().getPageFactory();
 	}
@@ -836,7 +833,7 @@ public abstract class Session implements
 	 * 
 	 * @return {@link IPageManager} instance.
 	 */
-	public final IPageManager getPageManager()
+	public IPageManager getPageManager()
 	{
 		return getApplication().getPageManager();
 	}