You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cashmand (via GitHub)" <gi...@apache.org> on 2024/03/14 00:16:39 UTC
[PR] [SPARK-45827] Refactor supportsDataType [spark]
cashmand opened a new pull request, #45506:
URL: https://github.com/apache/spark/pull/45506
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This is a follow-up to https://github.com/apache/spark/pull/45409. It refactors `supportsDataType` to use a non-recursive `supportsScalarDataType` method. This allows subclasses that just want to include or exclude one or two types to override with something like the following, rather than having to make a full copy of the recursive `supportsDataType` function, and risk getting out of sync as other types are changed in the base trait.
```
override def supportsScalarDataType(dt: DataType): Boolean = {
dt.isInstanceOf[VariantType] || super.supportsScalarDataType(dt)
}
```
### Why are the changes needed?
Allows subclasses to override the list of supported types with less duplicated code, and less risk of bugs.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Refactor supportsDataType [spark]
Posted by "cashmand (via GitHub)" <gi...@apache.org>.
cashmand closed pull request #45506: [SPARK-45827] Refactor supportsDataType
URL: https://github.com/apache/spark/pull/45506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Refactor supportsDataType [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45506:
URL: https://github.com/apache/spark/pull/45506#discussion_r1524065273
##########
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala:
##########
@@ -190,10 +210,7 @@ trait CreatableRelationProvider {
case MapType(k, v, _) => supportsDataType(k) && supportsDataType(v)
case StructType(fields) => fields.forall(f => supportsDataType(f.dataType))
case udt: UserDefinedType[_] => supportsDataType(udt.sqlType)
Review Comment:
This case match can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Refactor supportsDataType [spark]
Posted by "cashmand (via GitHub)" <gi...@apache.org>.
cashmand commented on PR #45506:
URL: https://github.com/apache/spark/pull/45506#issuecomment-1997391586
I realized that the example I gave in the PR description works just as well if we override `supportsDataType`, since the call to `super.supportsScalarDataType` will eventually call back into the subclass when it hits a scalar type recursively. So I don't think this PR really adds value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org