[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2333: Wrong default field in all service instance related scope

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request #2333: Wrong default field in all service instance related scope
URL: https://github.com/apache/incubator-skywalking/pull/2333
 
 
   Hi @peng-yongsheng @liuhaoyang 
   
   I think I made a mistake in the current OAL tool, which also triggers some related receiver code issue.
   All service instance scopes should add `service_id` rather than `service_instance_id`, because their `id`(`entity_id`) is service instance id. Also because of this, receiver set the wrong value to scope.
   
   I am correcting the issue in this PR.
   
   Notice, this issue wouldn't trigger any feature BUG at this moment, but it cause potential ones, if someone wants to do aggregation query based on all there sources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services