You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/05 09:00:14 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3657: ESP32&ESP32C3/hardware: Include files of the same level by their names only

Ouss4 commented on a change in pull request #3657:
URL: https://github.com/apache/incubator-nuttx/pull/3657#discussion_r626393716



##########
File path: arch/risc-v/src/esp32c3/hardware/esp32c3_gpio.h
##########
@@ -25,7 +25,7 @@
  * Included Files
  ****************************************************************************/
 
-#include "hardware/esp32c3_soc.h"
+#include "esp32c3_soc.h"
 

Review comment:
       > A safer solution would be to remove arch/xxx/src/xxx/hardware from the include search path and always preface the inclusion with hardware/.
   
   Is arch/xxx/src/xxx/hardware in the include search path?  I can't see it.
   As Gustavo mentioned this relies on the fact that `" "` includes will look first in the current directory.  I only changed files from that same directory.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org