[GitHub] [flink] rkhachatryan commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

[GitBox <gi...@apache.org>]

rkhachatryan commented on code in PR #20313:
URL: https://github.com/apache/flink/pull/20313#discussion_r926994558


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -162,7 +174,14 @@ public Set<Long> unregisterUnusedState(long lowestCheckpointID) {
                         subsumed.add(entry.stateHandle);
                     }
                     it.remove();
-                } else {
+                } else if (preventsDiscardingCreatedCheckpoint(entry)) {

Review Comment:
   `lowestCheckpointID` is still valid because it is not subsumed. It is `CheckpointSubsumeHelper` and checkpoint store that are responsible for subsumption.
    
   This method, however, returns potentially subsumed checkpoints but whose state might be in use by other checkpoints.
   I don't think these responsibilites should be mixed.
   
   Besides that, this seems unrelated to this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org