You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/11/08 16:25:45 UTC

[GitHub] [accumulo] keith-turner opened a new issue #1418: Remove DefaultMap and use computeIfAbsent instead.

keith-turner opened a new issue #1418: Remove DefaultMap and use computeIfAbsent instead.
URL: https://github.com/apache/accumulo/issues/1418
 
 
   I think [DefaultMap](https://github.com/apache/accumulo/blob/bbee47b8b95d230ba9def235917013dcfeaf7c38/server/base/src/main/java/org/apache/accumulo/server/util/DefaultMap.java) could be removed from the code.  There are currently two places in the code that create a DefaultMap.  I think these could instead create a HashMap and when `get()` is called on that hasmap use computeIfAbsent creating whatever DefaultMap would have created.
   
   Its only used in two places.  For the usage in `Master.getMasterMonitorInfo()` I think only the `get()` in that method needs to be replaced, nowhere else.  For the usage at `Master.badServers` I think only usage in `Master.gatherTableInformation()` needs to be updated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services