You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "edk12564 (via GitHub)" <gi...@apache.org> on 2026/08/10 05:32:13 UTC

[PR] Implement first steps for openbanking [fineract-consumer-facing]

edk12564 opened a new pull request, #97:
URL: https://github.com/apache/fineract-consumer-facing/pull/97

   Issues: https://github.com/apache/fineract-consumer-facing/issues/87
   
   # Summary
   
   Open banking was an important feature with a lot of interest. We should implement the start of openbanking infrastructure with the ability to act as a Spring Authorization Server to create open banking tokens. To start, we make sure to implement ES256 asymmetrical signing, JWTs, and openbanking endpoints to read User accounts. 
   
   We also added functionality to revoke openbanking consent, and keep these consents/sessions in database for consistency across nodes. Next, we implemented a frontend login redirect for openbanking authentication, and a consent revocation option in the Profile feature. 
   
   FInally as a side item, I noticed KYC could fall out of sync with Fineract, so KYC checks were added at token renewal for both login and openbanking tokens. If a user gets their KYC status revoked in Fineract, they will similarly get their access revoked in the BFF.
   
   ## More details
   
   - added Spring Authorization Server
   - implemented JDBC stateful tokens for consent/authorization checks
   - added openbanking scoped TPP tokens with refresh tokens and ES256 signatures
   - added KYC checks for each token refresh to keep BFF up to date with possible Fineract KYC revocations
   - added openbanking read endpoints for accounts and balances
   - added user consent revocation functionality
   - added Liquibase migrations for stateful openbanking tokens/consents
   - added consent approval page in frontend
   - added consent revocations to frontend
   - centralized code for kyc checks and frontend status badge styles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement first steps for openbanking [fineract-consumer-facing]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on code in PR #97:
URL: https://github.com/apache/fineract-consumer-facing/pull/97#discussion_r3755781327


##########
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/configs/OAuth2ConsumerProperties.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.consumer.infrastructure.configs;
+
+import java.time.Duration;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.ToString;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+@Getter
+@RequiredArgsConstructor
+@ConfigurationProperties("consumer.oauth2")

Review Comment:
   Maintain a top level constant here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement first steps for openbanking [fineract-consumer-facing]

Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on code in PR #97:
URL: https://github.com/apache/fineract-consumer-facing/pull/97#discussion_r3759245121


##########
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/configs/OAuth2ConsumerProperties.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.consumer.infrastructure.configs;
+
+import java.time.Duration;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.ToString;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+@Getter
+@RequiredArgsConstructor
+@ConfigurationProperties("consumer.oauth2")

Review Comment:
   Pushed an update now. Configuration properties are constants in every file across the codebase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement first steps for openbanking [fineract-consumer-facing]

Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on code in PR #97:
URL: https://github.com/apache/fineract-consumer-facing/pull/97#discussion_r3759038819


##########
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/configs/OAuth2ConsumerProperties.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.consumer.infrastructure.configs;
+
+import java.time.Duration;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.ToString;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+@Getter
+@RequiredArgsConstructor
+@ConfigurationProperties("consumer.oauth2")

Review Comment:
   Willdo! Thanks @Aman-Mittal.
   
   As for tests, I believe unit tests are in tests/ and e2e tests are in openbanking.feature and login.feature. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement first steps for openbanking [fineract-consumer-facing]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal merged PR #97:
URL: https://github.com/apache/fineract-consumer-facing/pull/97


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org