You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by clebertsuconic <gi...@git.apache.org> on 2016/10/06 01:43:00 UTC
[GitHub] qpid-proton pull request #82: optimizations on Decoder/Encoder
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton/pull/82
optimizations on Decoder/Encoder
- Avoiding multiple instances. The encoder and decoder can be used as singletons.
- There's still an option to instantiate your own encoder / decoder
- stateless Decoder/Encoder (can always reuse the same instance now)
- Implementing WritableBuffer and ReadableBuffers fully, so you could use NettyBuffers integrated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/qpid-proton singleton-encoder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit ffbf41ec626c2263a4bf9d1515440fddd40a1d14
Author: clebert suconic <cl...@gmail.com>
Date: 2014-05-02T14:38:11Z
optimizations on Decoder:
- Avoiding multiple instances. The encoder and decoder can be used as singletons.
- There's still an option to instantiate your own encoder / decoder
- stateless Decoder/Encoder (can always reuse the same instance now)
- Implementing WritableBuffer and ReadableBuffers fully, so you could use NettyBuffers integrated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
I will send this again on the new repo (in a week or so)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
@gemmellr there's a failure in one of these CIs.. what test is that? it doesn't seem related.
Can you check please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
This is the first thing I wanted to do on the encoders / decoders.
There's a next step where I can integrate my own Buffer on Transports (or maybe a refactored version of it)...
This is at least the first step. Tests are running fine... and the performance tests I made are ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/qpid-proton/pull/82
Would suggest removing the author tags from the new files, they are discouraged by the ASF
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #82: optimizations on Decoder/Encoder
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic closed the pull request at:
https://github.com/apache/qpid-proton/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
@tabish121 done.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #82: optimizations on Decoder/Encoder
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton/pull/82
Its the python-based test suite that is failing to run against proton-j.
It seems like Appveyor have added Maven to the build nodes in the last couple weeks, which they didn't previously do, and the cmake build is failing to run the tests against proton-j now, whereas before it likely wasn't trying to run them at all (as noone downloaded maven in the Appveyor build config). I cant say I've ever run them on Windows myself, and certainly not via the cmake build...something to look at.
I've not yet had time to look properly at the PR itself, in part given how huge it is. Its obviously a breaking change anyway so it won't be going in the imminent 0.15.0 release, I'll look after that is out the way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org