[GitHub] [nifi] Lehel44 commented on a change in pull request #5111: NIFI-8645: Disable LongRunningTaskMonitor by default

[GitBox <gi...@apache.org>]

Lehel44 commented on a change in pull request #5111:
URL: https://github.com/apache/nifi/pull/5111#discussion_r644068907



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties
##########
@@ -321,5 +321,5 @@ nifi.analytics.connection.model.score.name=${nifi.analytics.connection.model.sco
 nifi.analytics.connection.model.score.threshold=${nifi.analytics.connection.model.score.threshold}
 
 # runtime monitoring properties
-nifi.monitor.long.running.task.schedule=${nifi.monitor.long.running.task.schedule}
-nifi.monitor.long.running.task.threshold=${nifi.monitor.long.running.task.threshold}
+nifi.monitor.long.running.task.schedule=

Review comment:
       I think it's a good practice to include the measurement unit in the property name or to mention it in a comment above. Relying on other, already provided property values, could be either 10 secs or 10 sec, or just 10.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org