You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/05/07 16:20:00 UTC
Review Request 21158: TAJO-816: NULL delimiter doesn't apply with
HCatalogStore.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21158/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-816
https://issues.apache.org/jira/browse/TAJO-816
Repository: tajo
Description
-------
If we use _csvfile.null_ with HCatalogStore, it will run without some exceptions. But we can't find _serialization.null.format_ parameter on Hive as follows:
* Tajo
{code:xml}
create external table table2 (id int, name text, score float, type text) using csv with ('csvfile.delimiter'='|','csvfile.null'=''
> ) location 'hdfs://localhost:9010/tajo/warehouse/table2' ;
{code}
* Hive
{code:xml}
hive> show create table table2;
OK
CREATE EXTERNAL TABLE table2(
id int COMMENT '',
name string COMMENT '',
score float COMMENT '',
type string COMMENT '')
ROW FORMAT DELIMITED
FIELDS TERMINATED BY '|'
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://localhost:9010/tajo/warehouse/table2'
TBLPROPERTIES (
'csvfile.null'='',
'transient_lastDdlTime'='1399433333',
'csvfile.delimiter'='|')
{code}
Diffs
-----
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7a694fa
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java a862baf
Diff: https://reviews.apache.org/r/21158/diff/
Testing
-------
mvn clean install -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore
Thanks,
Jung JaeHwa
Re: Review Request 21158: TAJO-816: NULL delimiter doesn't apply with
HCatalogStore.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21158/#review42663
-----------------------------------------------------------
Ship it!
+1
The patch looks good to me.
- Hyunsik Choi
On May 7, 2014, 11:19 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21158/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 11:19 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-816
> https://issues.apache.org/jira/browse/TAJO-816
>
>
> Repository: tajo
>
>
> Description
> -------
>
> If we use _csvfile.null_ with HCatalogStore, it will run without some exceptions. But we can't find _serialization.null.format_ parameter on Hive as follows:
>
> * Tajo
> {code:xml}
> create external table table2 (id int, name text, score float, type text) using csv with ('csvfile.delimiter'='|','csvfile.null'=''
> > ) location 'hdfs://localhost:9010/tajo/warehouse/table2' ;
> {code}
>
> * Hive
> {code:xml}
> hive> show create table table2;
> OK
> CREATE EXTERNAL TABLE table2(
> id int COMMENT '',
> name string COMMENT '',
> score float COMMENT '',
> type string COMMENT '')
> ROW FORMAT DELIMITED
> FIELDS TERMINATED BY '|'
> STORED AS INPUTFORMAT
> 'org.apache.hadoop.mapred.TextInputFormat'
> OUTPUTFORMAT
> 'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
> LOCATION
> 'hdfs://localhost:9010/tajo/warehouse/table2'
> TBLPROPERTIES (
> 'csvfile.null'='',
> 'transient_lastDdlTime'='1399433333',
> 'csvfile.delimiter'='|')
> {code}
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7a694fa
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java a862baf
>
> Diff: https://reviews.apache.org/r/21158/diff/
>
>
> Testing
> -------
>
> mvn clean install -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore
>
>
> Thanks,
>
> Jung JaeHwa
>
>