You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@joshua.apache.org by mj...@apache.org on 2016/08/21 17:42:22 UTC

[13/22] incubator-joshua git commit: JOSHUA-301 - Add findbugs plugin.

JOSHUA-301 - Add findbugs plugin.

Currently this can be run with 'mvn findbugs:check'. There are a ton of warnings, however,
which currently fail the build. Perhaps once fixed this auto-build failure can be added
in, but at present there are too many warnings to fix immediately.


Project: http://git-wip-us.apache.org/repos/asf/incubator-joshua/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-joshua/commit/dccb48bc
Tree: http://git-wip-us.apache.org/repos/asf/incubator-joshua/tree/dccb48bc
Diff: http://git-wip-us.apache.org/repos/asf/incubator-joshua/diff/dccb48bc

Branch: refs/heads/JOSHUA-284
Commit: dccb48bcc0ab76faaa3b9f3e58823b5fa66ea983
Parents: 2e2ee09
Author: Max Thomas <ma...@maxthomas.io>
Authored: Wed Aug 17 10:13:37 2016 -0500
Committer: Max Thomas <ma...@maxthomas.io>
Committed: Wed Aug 17 10:13:37 2016 -0500

----------------------------------------------------------------------
 pom.xml | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-joshua/blob/dccb48bc/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 49d77fb..0229554 100644
--- a/pom.xml
+++ b/pom.xml
@@ -37,7 +37,9 @@
 
   <properties>
     <slf4j.version>1.7.21</slf4j.version>
+    <findbugs.version>3.0.4</findbugs.version>
   </properties>
+
   <licenses>
     <license>
       <name>The Apache Software License, Version 2.0</name>
@@ -120,6 +122,24 @@
     <testOutputDirectory>${basedir}/target/test-classes</testOutputDirectory>
     <sourceDirectory>${basedir}/src/main/java</sourceDirectory>
     <testSourceDirectory>${basedir}/src/test/java</testSourceDirectory>
+
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <version>${findbugs.version}</version>
+          <configuration>
+            <xmlOutput>true</xmlOutput>
+            <effort>Max</effort>
+            <failOnError>true</failOnError>
+            <includeTests>true</includeTests>
+            <maxRank>16</maxRank>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
@@ -169,6 +189,11 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+        <version>${findbugs.version}</version>
+      </plugin>
     </plugins>
   </build>
   <dependencies>
@@ -232,9 +257,9 @@
       <version>${slf4j.version}</version>
     </dependency>
     <dependency>
-        <groupId>concurrent</groupId>
-        <artifactId>concurrent</artifactId>
-        <version>1.3.4</version>
+      <groupId>concurrent</groupId>
+      <artifactId>concurrent</artifactId>
+      <version>1.3.4</version>
     </dependency>
 
     <!-- Test Dependencies -->