You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/18 10:23:29 UTC
[GitHub] [flink] matriv opened a new pull request, #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
matriv opened a new pull request, #19507:
URL: https://github.com/apache/flink/pull/19507
## What is the purpose of the change
Revert behaviour of binary to string casts and vice versa, to not use
hex enconding/decoding, but simple UTF-8 bytes transformation from a
byte[] to a string and vice versa.
## Verifying this change
Adjusted the tests accordingly in
- `CastFunctionITCase`
- `CastRulesTest`
- `ScalarFunctionsTest`
- `CastFunctionMiscITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
URL: https://github.com/apache/flink/pull/19507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102484323
@twalthr Please take care of the final commit message when you squash the commits before merging, I've already updated the text in the description of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102261764
@wuchong I'm working to do the printing into an `x'AF32DCF` string. (when printing results in console)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102181420
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
wuchong commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102331036
I think we can separate them into 2 issues. I think the printing doesn't need to be a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1101295844
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5b482770b9a586c21d7197c8107478410a125830",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5b482770b9a586c21d7197c8107478410a125830",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b482770b9a586c21d7197c8107478410a125830 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
wuchong commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102244219
The change looks good to me. Would be better @twalthr to have another look. I'm also fine with using hex representation when printing binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
twalthr commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102334406
@wuchong I agree that those can be 2 issues. But the implementation for the updated printing should be minimal. Both issues can be implemented and merged today. Otherwise we will only merge the blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19507: [FLINK-27212][table-planner] Revert binary<->string cast behaviour
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19507:
URL: https://github.com/apache/flink/pull/19507#issuecomment-1102357627
I just pushed the change of the printing in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org