You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/23 14:21:57 UTC
[GitHub] [incubator-apisix] lilien1010 opened a new pull request #1332:
deletion: drop webdocket enable control in proxy-rewrite plugin
lilien1010 opened a new pull request #1332: deletion: drop webdocket enable control in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/1332
### Summary
remove websocket related code in proxy-rewrite plugin
### Full changelog
* doc/plugins/proxy-rewrite-cn.md
* doc/plugins/proxy-rewrite-cn.md
* lua/apisix/plugins/proxy-rewrite.lua
* lua/apisix/plugins/proxy-rewrite.lua
### Issues resolved
Fix https://github.com/apache/incubator-apisix/issues/1331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1332: deletion:
drop webdocket enable control in proxy-rewrite plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1332: deletion: drop webdocket enable control in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/1332#issuecomment-603244789
@lilien1010 It is recommended to increase the version number of this plugin.
https://github.com/lilien1010/apisix/blob/0ff8ece5da827f5c5a8349361d501cbeb7eac3a9/lua/apisix/plugins/proxy-rewrite.lua#L68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1332: deletion:
drop webdocket enable control in proxy-rewrite plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1332: deletion: drop webdocket enable control in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/1332#issuecomment-602931823
@lilien1010 please take a look at the output of CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 merged pull request #1332: deletion:
drop webdocket enable control in proxy-rewrite plugin
Posted by GitBox <gi...@apache.org>.
lilien1010 merged pull request #1332: deletion: drop webdocket enable control in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/1332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1332: deletion:
drop webdocket enable control in proxy-rewrite plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1332: deletion: drop webdocket enable control in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/1332#issuecomment-602681258
This is a backwards incompatible modification and should be specifically noted in PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services