You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/01/06 09:18:47 UTC

[GitHub] spark pull request #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for ...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20173

    [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNondeterministic for wrapped UDF function

    ## What changes were proposed in this pull request?
    
    This PR wraps the `asNondeterministic` attribute in the wrapped UDF function to set the docstring properly.
    
    ```python
    from pyspark.sql.functions import udf
    help(udf(lambda x: x).asNondeterministic)
    ```
    
    Before:
    
    ```
    Help on function <lambda> in module pyspark.sql.udf:
    
    <lambda> lambda
    (END
    ```
    
    After:
    
    ```
    Help on function asNondeterministic in module pyspark.sql.udf:
    
    asNondeterministic()
        Updates UserDefinedFunction to nondeterministic.
    
        .. versionadded:: 2.3
    (END)
    ```
    
    ## How was this patch tested?
    
    Manually tested and a simple test was added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-22901-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20173
    
----
commit d92dac3f73f8bd0f72ee04e5a2fbccc3887b4b4b
Author: hyukjinkwon <gu...@...>
Date:   2018-01-06T09:13:59Z

    Adds the doc for asNondeterministic for wrapped UDF function

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20173
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20173
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85749/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20173


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20173
  
    **[Test build #85749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85749/testReport)** for PR 20173 at commit [`d92dac3`](https://github.com/apache/spark/commit/d92dac3f73f8bd0f72ee04e5a2fbccc3887b4b4b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20173: [SPARK-22901][PYTHON][FOLLOWUP] Adds the doc for asNonde...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20173
  
    **[Test build #85749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85749/testReport)** for PR 20173 at commit [`d92dac3`](https://github.com/apache/spark/commit/d92dac3f73f8bd0f72ee04e5a2fbccc3887b4b4b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org