You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Nishant Bangarwa (JIRA)" <ji...@apache.org> on 2018/01/07 18:53:03 UTC

[jira] [Commented] (CALCITE-2122) Continuum of DateRangeRules issues.

    [ https://issues.apache.org/jira/browse/CALCITE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315423#comment-16315423 ] 

Nishant Bangarwa commented on CALCITE-2122:
-------------------------------------------

submitted a fix here - https://github.com/apache/calcite/pull/599
[~julianhyde] please review. 

> Continuum of DateRangeRules issues.
> -----------------------------------
>
>                 Key: CALCITE-2122
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2122
>             Project: Calcite
>          Issue Type: Bug
>          Components: core, druid
>            Reporter: slim bouguerra
>            Assignee: Nishant Bangarwa
>
> The following test at org.apache.calcite.test.DruidAdapterIT
> {code}
> @Test
>   public void testCombinationOfValidAndNotValidAndInterval() {
>     final String sql = "SELECT COUNT(*) FROM \"foodmart\" "
>         + "WHERE  \"timestamp\" < CAST('1997-01-02' as TIMESTAMP) AND "
>         + "EXTRACT(MONTH FROM \"timestamp\") = 01 AND EXTRACT(YEAR FROM \"timestamp\") = 01 ";
>     sql(sql, FOODMART)
>         .runs();
>   }
> {code}
> Leads to 
> {code}
> java.lang.RuntimeException: exception while executing [SELECT COUNT(*) FROM "foodmart" WHERE  "timestamp" < CAST('1997-01-02' as TIMESTAMP) AND EXTRACT(MONTH FROM "timestamp") = 01 AND EXTRACT(YEAR FROM "timestamp") = 01 ]
> 	at org.apache.calcite.test.CalciteAssert$AssertQuery.runs(CalciteAssert.java:1411)
> 	at org.apache.calcite.test.DruidAdapterIT.testCombinationOfValidAndNotValidAndInterval(DruidAdapterIT.java:3497)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> 	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> 	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> 	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
> 	at org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:600)
> 	at org.apache.calcite.test.CalciteAssert$AssertQuery.runs(CalciteAssert.java:1407)
> 	... 23 more
> Caused by: java.sql.SQLException: Error while executing SQL "SELECT COUNT(*) FROM "foodmart" WHERE  "timestamp" < CAST('1997-01-02' as TIMESTAMP) AND EXTRACT(MONTH FROM "timestamp") = 01 AND EXTRACT(YEAR FROM "timestamp") = 01 ": Error while applying rule FilterDateRangeRule, args [rel#19:LogicalFilter.NONE.[](input=rel#18:Subset#0.BINDABLE.[],condition=AND(<($0, CAST('1997-01-02'):TIMESTAMP(0) NOT NULL), =(EXTRACT(FLAG(MONTH), $0), 1), =(EXTRACT(FLAG(YEAR), $0), 1)))]
> 	at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
> 	at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
> 	at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:156)
> 	at org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:218)
> 	at org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:568)
> 	... 24 more
> Caused by: java.lang.RuntimeException: Error while applying rule FilterDateRangeRule, args [rel#19:LogicalFilter.NONE.[](input=rel#18:Subset#0.BINDABLE.[],condition=AND(<($0, CAST('1997-01-02'):TIMESTAMP(0) NOT NULL), =(EXTRACT(FLAG(MONTH), $0), 1), =(EXTRACT(FLAG(YEAR), $0), 1)))]
> 	at org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:236)
> 	at org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:650)
> 	at org.apache.calcite.tools.Programs$5.run(Programs.java:326)
> 	at org.apache.calcite.tools.Programs$SequenceProgram.run(Programs.java:387)
> 	at org.apache.calcite.prepare.Prepare.optimize(Prepare.java:188)
> 	at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:319)
> 	at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:230)
> 	at org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:781)
> 	at org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:640)
> 	at org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:610)
> 	at org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:221)
> 	at org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:603)
> 	at org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:638)
> 	at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:149)
> 	... 26 more
> Caused by: java.lang.ClassCastException: org.apache.calcite.util.TimestampString cannot be cast to org.apache.calcite.util.DateString
> 	at org.apache.calcite.util.DateString.compareTo(DateString.java:32)
> 	at org.apache.calcite.rex.RexSimplify.processRange(RexSimplify.java:1109)
> 	at org.apache.calcite.rex.RexSimplify.simplifyAnd2ForUnknownAsFalse(RexSimplify.java:711)
> 	at org.apache.calcite.rex.RexSimplify.simplifyAnd2ForUnknownAsFalse(RexSimplify.java:579)
> 	at org.apache.calcite.rex.RexSimplify.simplifyAnds(RexSimplify.java:253)
> 	at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:936)
> 	at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:926)
> 	at org.apache.calcite.rel.rules.DateRangeRules$FilterDateRangeRule.onMatch(DateRangeRules.java:179)
> 	at org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:212)
> 	... 39 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)