You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by gef756 <gi...@git.apache.org> on 2017/10/11 00:20:18 UTC
[GitHub] zeppelin pull request #2617: ZEPPELIN-2985: correct grammar in keyboard tool...
GitHub user gef756 opened a pull request:
https://github.com/apache/zeppelin/pull/2617
ZEPPELIN-2985: correct grammar in keyboard tooltip
### What is this PR for?
The tooltip for "List of shortcut" should read "List of shortcuts" (plural).
### What type of PR is it?
Bug Fix
### Todos
* N/A
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2985
### How should this be tested?
* Hover over tooltip. Ensure that tooltip contains changes and behaves like a
tooltip. (Shows up then hides based on cursor position)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gef756/zeppelin dev-kb-tooltip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2617
----
commit b0365de909e671c7dae8a2da7cbd4aa4f265d70c
Author: Gabe Fernando <ge...@gmail.com>
Date: 2017-10-09T22:19:22Z
ENH: correct grammar in keyboard tooltip
----
---
[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2617
Thanks @gef756 for the contribution!
Merge to master
---
[GitHub] zeppelin pull request #2617: ZEPPELIN-2985: correct grammar in keyboard tool...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2617
---
[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2617
Thanks @gef756 for the fix. LGTM
---
[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2617
I tried to search other typo but couldn't find (for viable text, not for css class things). LGTM.
---
[GitHub] zeppelin issue #2617: ZEPPELIN-2985: correct grammar in keyboard tooltip
Posted by gef756 <gi...@git.apache.org>.
Github user gef756 commented on the issue:
https://github.com/apache/zeppelin/pull/2617
Cool! Do you guys need anything else from my end?
---