You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 18:59:22 UTC
[GitHub] [airflow] dimberman opened a new pull request #11597: raises a warning for provide_context instead of killing the task
dimberman opened a new pull request #11597:
URL: https://github.com/apache/airflow/pull/11597
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11597: Raises a warning for provide_context instead of killing the task
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11597:
URL: https://github.com/apache/airflow/pull/11597#discussion_r506677382
##########
File path: airflow/operators/python.py
##########
@@ -85,6 +86,9 @@ def __init__(
templates_exts: Optional[List[str]] = None,
**kwargs
) -> None:
+ if kwargs.get("provide_context"):
+ warnings.warn("provide_context is deprecated as of 2.0 and is no longer required")
+ kwargs.pop('provide_context', None)
Review comment:
```suggestion
if kwargs.get("provide_context"):
warnings.warn("provide_context is deprecated as of 2.0 and is no longer required", DeprecationWarning, stacklevel=2)
kwargs.pop('provide_context', None)
```
This should take care of @ashb 's suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11597: Raises a warning for provide_context instead of killing the task
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11597:
URL: https://github.com/apache/airflow/pull/11597#issuecomment-710644860
I don't know if using kwargs is the best idea in this case. I have to check if the IDE supports it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #11597: Raises a warning for provide_context instead of killing the task
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #11597:
URL: https://github.com/apache/airflow/pull/11597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11597: Raises a warning for provide_context instead of killing the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11597:
URL: https://github.com/apache/airflow/pull/11597#issuecomment-710609083
[The Workflow run](https://github.com/apache/airflow/actions/runs/311403614) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11597: Raises a warning for provide_context instead of killing the task
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11597:
URL: https://github.com/apache/airflow/pull/11597#issuecomment-710645488
Just an FYI for future reviewers, we already have the following line in `Updating.md`:
> The change is backwards compatible, setting provide_context will add the provide_context variable to the kwargs (but won't do anything).
https://github.com/apache/airflow/blob/master/UPDATING.md#airflowoperatorspythonpythonoperator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org