[GitHub] [incubator-kvrocks] WyattJia commented on a diff in pull request #610: Update max_bytes_for_level_base unit to bytes and remove unuseful error checker.

[GitBox <gi...@apache.org>]

WyattJia commented on code in PR #610:
URL: https://github.com/apache/incubator-kvrocks/pull/610#discussion_r884895680


##########
src/config.cc:
##########
@@ -449,26 +449,17 @@ void Config::initFieldCallback() {
       }},
       {"rocksdb.max_bytes_for_level_base", [this](Server* srv, const std::string &k, const std::string& v)->Status {
         if (!srv) return Status::OK();
-        if (!RocksDB.level_compaction_dynamic_level_bytes) {

Review Comment:
   
   
   
   > Copy comment from [#611 (comment)](https://github.com/apache/incubator-kvrocks/pull/611#discussion_r884190774):
   > 
   > Why do you make these changes?
   
   After my discussion with @ShooterIT , we believe that this configuration item may not be required. If the configuration is not filled in, an error should not be returned, and the default value should be set to false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org