You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/03/28 16:23:01 UTC
[GitHub] [ignite] ololo3000 opened a new pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
ololo3000 opened a new pull request #8941:
URL: https://github.com/apache/ignite/pull/8941
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 commented on pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#issuecomment-810996055
@Nikita-tech-writer Thanks for the comments. I have fixed all of them. Could you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604799681
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -152,17 +184,37 @@ public class SpringAppCfg {
}
}
----
+tab:Ignite thin client connection configuration[]
+[source,java]
+----
+@Configuration
+@EnableIgniteRepositories
+public class SpringAppCfg {
+ /**
+ * Creating Apache Ignite thin client instance bean. A bean will be passed to the IgniteRepositoryFactoryBean to
+ * connect to the Ignite cluster and perform cache operations.
+ */
+ @Bean
+ public IgniteClient igniteInstance() {
+ return Ignition.startClient(new ClientConfiguration().setAddresses("127.0.0.1:10800");;
+ }
+}
+----
--
-The configuration has to instantiate Apache Ignite bean (node) that will be passed to `IgniteRepositoryFactoryBean`
-and will be used by all the Apache Ignite repositories in order to connect to the cluster.
+The configuration has to instantiate Apache Ignite bean (node) or Apache Ignite thin client bean that will be passed to
+`IgniteRepositoryFactoryBean` and will be used by all the Apache Ignite repositories in order to connect to the cluster.
Review comment:
In the docs, we'd better stick to the absolute present tense as much as we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604819250
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -113,13 +141,17 @@ Instead of these operations you can use Ignite specific counterparts available v
== Spring Data and Apache Ignite Configuration
+Apache Ignite Spring Data integration supports connecting to Apache Ignite cluster through Apache Ignite node or
+Apache Ignite thin client. Both approaches to configuring access to Apache Ignite cluster use the same API shown below.
+Apache Ignite Spring Data integration automatically recognizes the type of provided bean and uses the appropriate cluster
+connection.
Review comment:
I were not intended to start every sentence of the paragraph from the new line. Just broke line after 120 characters. Сan i do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604799108
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -152,17 +184,37 @@ public class SpringAppCfg {
}
}
----
+tab:Ignite thin client connection configuration[]
+[source,java]
+----
+@Configuration
+@EnableIgniteRepositories
+public class SpringAppCfg {
+ /**
+ * Creating Apache Ignite thin client instance bean. A bean will be passed to the IgniteRepositoryFactoryBean to
+ * connect to the Ignite cluster and perform cache operations.
+ */
+ @Bean
+ public IgniteClient igniteInstance() {
+ return Ignition.startClient(new ClientConfiguration().setAddresses("127.0.0.1:10800");;
+ }
+}
+----
--
-The configuration has to instantiate Apache Ignite bean (node) that will be passed to `IgniteRepositoryFactoryBean`
-and will be used by all the Apache Ignite repositories in order to connect to the cluster.
+The configuration has to instantiate Apache Ignite bean (node) or Apache Ignite thin client bean that will be passed to
+`IgniteRepositoryFactoryBean` and will be used by all the Apache Ignite repositories in order to connect to the cluster.
Review comment:
```suggestion
The configuration has to instantiate the Apache Ignite bean (node) or the Apache Ignite thin client bean that is passed to `IgniteRepositoryFactoryBean` and is used by all the Apache Ignite repositories in order to connect to the cluster.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604820222
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -152,17 +184,37 @@ public class SpringAppCfg {
}
}
----
+tab:Ignite thin client connection configuration[]
+[source,java]
+----
+@Configuration
+@EnableIgniteRepositories
+public class SpringAppCfg {
+ /**
+ * Creating Apache Ignite thin client instance bean. A bean will be passed to the IgniteRepositoryFactoryBean to
+ * connect to the Ignite cluster and perform cache operations.
+ */
+ @Bean
+ public IgniteClient igniteInstance() {
+ return Ignition.startClient(new ClientConfiguration().setAddresses("127.0.0.1:10800");;
+ }
+}
+----
--
-The configuration has to instantiate Apache Ignite bean (node) that will be passed to `IgniteRepositoryFactoryBean`
-and will be used by all the Apache Ignite repositories in order to connect to the cluster.
+The configuration has to instantiate Apache Ignite bean (node) or Apache Ignite thin client bean that will be passed to
+`IgniteRepositoryFactoryBean` and will be used by all the Apache Ignite repositories in order to connect to the cluster.
Review comment:
Got it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604819250
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -113,13 +141,17 @@ Instead of these operations you can use Ignite specific counterparts available v
== Spring Data and Apache Ignite Configuration
+Apache Ignite Spring Data integration supports connecting to Apache Ignite cluster through Apache Ignite node or
+Apache Ignite thin client. Both approaches to configuring access to Apache Ignite cluster use the same API shown below.
+Apache Ignite Spring Data integration automatically recognizes the type of provided bean and uses the appropriate cluster
+connection.
Review comment:
I were not intended to start every sentence of the paragraph from the new line. Just broke line after 120 characters. Сan I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604797163
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -113,13 +141,17 @@ Instead of these operations you can use Ignite specific counterparts available v
== Spring Data and Apache Ignite Configuration
+Apache Ignite Spring Data integration supports connecting to Apache Ignite cluster through Apache Ignite node or
+Apache Ignite thin client. Both approaches to configuring access to Apache Ignite cluster use the same API shown below.
+Apache Ignite Spring Data integration automatically recognizes the type of provided bean and uses the appropriate cluster
+connection.
Review comment:
```suggestion
Apache Ignite Spring Data integration supports connecting to the Apache Ignite cluster through the Apache Ignite node or Apache Ignite thin client. Both approaches to configuring access to the Apache Ignite cluster use the same API shown below. Apache Ignite Spring Data integration automatically recognizes the type of the provided bean and uses the appropriate cluster connection.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604798254
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -113,13 +141,17 @@ Instead of these operations you can use Ignite specific counterparts available v
== Spring Data and Apache Ignite Configuration
+Apache Ignite Spring Data integration supports connecting to Apache Ignite cluster through Apache Ignite node or
+Apache Ignite thin client. Both approaches to configuring access to Apache Ignite cluster use the same API shown below.
+Apache Ignite Spring Data integration automatically recognizes the type of provided bean and uses the appropriate cluster
+connection.
Review comment:
If it's not an ordered/unordered list, then we'd better not start every sentence of the paragraph from the new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8941:
URL: https://github.com/apache/ignite/pull/8941#discussion_r604800334
##########
File path: docs/_docs/extensions-and-integrations/spring/spring-data.adoc
##########
@@ -152,17 +184,37 @@ public class SpringAppCfg {
}
}
----
+tab:Ignite thin client connection configuration[]
+[source,java]
+----
+@Configuration
+@EnableIgniteRepositories
+public class SpringAppCfg {
+ /**
+ * Creating Apache Ignite thin client instance bean. A bean will be passed to the IgniteRepositoryFactoryBean to
+ * connect to the Ignite cluster and perform cache operations.
+ */
+ @Bean
+ public IgniteClient igniteInstance() {
+ return Ignition.startClient(new ClientConfiguration().setAddresses("127.0.0.1:10800");;
+ }
+}
+----
--
-The configuration has to instantiate Apache Ignite bean (node) that will be passed to `IgniteRepositoryFactoryBean`
-and will be used by all the Apache Ignite repositories in order to connect to the cluster.
+The configuration has to instantiate Apache Ignite bean (node) or Apache Ignite thin client bean that will be passed to
+`IgniteRepositoryFactoryBean` and will be used by all the Apache Ignite repositories in order to connect to the cluster.
In the example above, the bean is initialized directly by the application and is named `igniteInstance`.
Alternatively, the following beans can be registered in your configuration and an Apache Ignite node will be started automatically:
* `IgniteConfiguration` object named as `igniteCfg` bean.
* A path to Apache Ignite's Spring XML configuration named `igniteSpringCfgPath`.
+In the case of connecting to the cluster via Apache Ignite thin client, you can alternatively register the
+`ClientConfiguration` bean named `igniteCfg` so that the Apache Ignite thin client instance will be started automatically
+ by Apache Ignite Spring Data integration.
Review comment:
```suggestion
In the case of connecting to the cluster via Apache Ignite thin client, you can alternatively register the `ClientConfiguration` bean named `igniteCfg` so that the Apache Ignite thin client instance is started automatically by the Apache Ignite Spring Data integration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev merged pull request #8941: IGNITE-14398 Documents thin client support for spring-data integration.
Posted by GitBox <gi...@apache.org>.
NSAmelchev merged pull request #8941:
URL: https://github.com/apache/ignite/pull/8941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org